mirror of
https://github.com/AdrianKuta/KahootQuiz.git
synced 2025-09-14 17:24:21 +02:00
Adrian Kuta
59218cc2e1
This commit refactors how `ScreenUiState` is produced in `QuizScreenViewModel` by extracting the logic into a private `screenUiState` function that combines various flows. It also introduces `Result` sealed interface and `asResult()` Flow extension for handling asynchronous operations. Additionally, lint baseline files have been added to all modules and a Detekt configuration file for the `ui:quiz` module.
Key changes:
- **ViewModel Refactoring (`ui:quiz` module):**
- Introduced `Result.kt` with a sealed interface for `Success`, `Error`, and `Loading` states, along with an `asResult()` extension function for `Flow` to wrap emissions in `Result`.
- In `QuizScreenViewModel.kt`:
- The `quiz` state flow now uses `asResult()` and maps the `Result` to `QuizUiState`, handling potential error states by defaulting to `QuizUiState.Loading` (actual error UI handling is noted as a TODO).
- The logic for combining flows to produce `ScreenUiState` has been extracted into a new private function `screenUiState()`. This function takes the necessary flows as parameters and returns a `Flow<ScreenUiState>`.
- The `uiState` flow now uses this new `screenUiState()` function for its production.
- **Lint and Detekt Configuration:**
- Added `lint-baseline.xml` files to the following modules to establish a baseline for lint warnings:
- `app`
- `core/designsystem`
- `core/network`
- `domain`
- `model/data`
- `ui/quiz`
- Added `config/detekt/detekt.yml` to the `ui:quiz` module to configure Detekt rules, including exceptions for Jetpack Compose naming conventions, complexity rules for Composable functions, and style guidelines for magic numbers and unused private members. It also enables trailing commas for call sites and declaration sites.
- **Binary File:**
- Added `App.apk`.
159 lines
5.6 KiB
XML
159 lines
5.6 KiB
XML
<?xml version="1.0" encoding="UTF-8"?>
|
|
<issues format="6" by="lint 8.13.0-rc02" type="baseline" client="gradle" dependencies="false" name="AGP (8.13.0-rc02)" variant="all" version="8.13.0-rc02">
|
|
|
|
<issue
|
|
id="UnusedAttribute"
|
|
message="Attribute `endX` is only used in API level 24 and higher (current min is 23)"
|
|
errorLine1=" android:endX="85.84757""
|
|
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~">
|
|
<location
|
|
file="src/main/res/drawable/ic_launcher_foreground.xml"
|
|
line="10"
|
|
column="17"/>
|
|
</issue>
|
|
|
|
<issue
|
|
id="UnusedAttribute"
|
|
message="Attribute `endY` is only used in API level 24 and higher (current min is 23)"
|
|
errorLine1=" android:endY="92.4963""
|
|
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~">
|
|
<location
|
|
file="src/main/res/drawable/ic_launcher_foreground.xml"
|
|
line="11"
|
|
column="17"/>
|
|
</issue>
|
|
|
|
<issue
|
|
id="UnusedAttribute"
|
|
message="Attribute `startX` is only used in API level 24 and higher (current min is 23)"
|
|
errorLine1=" android:startX="42.9492""
|
|
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~">
|
|
<location
|
|
file="src/main/res/drawable/ic_launcher_foreground.xml"
|
|
line="12"
|
|
column="17"/>
|
|
</issue>
|
|
|
|
<issue
|
|
id="UnusedAttribute"
|
|
message="Attribute `startY` is only used in API level 24 and higher (current min is 23)"
|
|
errorLine1=" android:startY="49.59793""
|
|
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~">
|
|
<location
|
|
file="src/main/res/drawable/ic_launcher_foreground.xml"
|
|
line="13"
|
|
column="17"/>
|
|
</issue>
|
|
|
|
<issue
|
|
id="UnusedAttribute"
|
|
message="Attribute `offset` is only used in API level 24 and higher (current min is 23)"
|
|
errorLine1=" android:offset="0.0" />"
|
|
errorLine2=" ~~~~~~~~~~~~~~~~~~~~">
|
|
<location
|
|
file="src/main/res/drawable/ic_launcher_foreground.xml"
|
|
line="17"
|
|
column="21"/>
|
|
</issue>
|
|
|
|
<issue
|
|
id="UnusedAttribute"
|
|
message="Attribute `offset` is only used in API level 24 and higher (current min is 23)"
|
|
errorLine1=" android:offset="1.0" />"
|
|
errorLine2=" ~~~~~~~~~~~~~~~~~~~~">
|
|
<location
|
|
file="src/main/res/drawable/ic_launcher_foreground.xml"
|
|
line="20"
|
|
column="21"/>
|
|
</issue>
|
|
|
|
<issue
|
|
id="UnusedAttribute"
|
|
message="Attribute `fillType` is only used in API level 24 and higher (current min is 23)"
|
|
errorLine1=" android:fillType="nonZero""
|
|
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~">
|
|
<location
|
|
file="src/main/res/drawable/ic_launcher_foreground.xml"
|
|
line="26"
|
|
column="9"/>
|
|
</issue>
|
|
|
|
<issue
|
|
id="UnusedResources"
|
|
message="The resource `R.color.purple_200` appears to be unused"
|
|
errorLine1=" <color name="purple_200">#FFBB86FC</color>"
|
|
errorLine2=" ~~~~~~~~~~~~~~~~~">
|
|
<location
|
|
file="src/main/res/values/colors.xml"
|
|
line="3"
|
|
column="12"/>
|
|
</issue>
|
|
|
|
<issue
|
|
id="UnusedResources"
|
|
message="The resource `R.color.purple_500` appears to be unused"
|
|
errorLine1=" <color name="purple_500">#FF6200EE</color>"
|
|
errorLine2=" ~~~~~~~~~~~~~~~~~">
|
|
<location
|
|
file="src/main/res/values/colors.xml"
|
|
line="4"
|
|
column="12"/>
|
|
</issue>
|
|
|
|
<issue
|
|
id="UnusedResources"
|
|
message="The resource `R.color.purple_700` appears to be unused"
|
|
errorLine1=" <color name="purple_700">#FF3700B3</color>"
|
|
errorLine2=" ~~~~~~~~~~~~~~~~~">
|
|
<location
|
|
file="src/main/res/values/colors.xml"
|
|
line="5"
|
|
column="12"/>
|
|
</issue>
|
|
|
|
<issue
|
|
id="UnusedResources"
|
|
message="The resource `R.color.teal_200` appears to be unused"
|
|
errorLine1=" <color name="teal_200">#FF03DAC5</color>"
|
|
errorLine2=" ~~~~~~~~~~~~~~~">
|
|
<location
|
|
file="src/main/res/values/colors.xml"
|
|
line="6"
|
|
column="12"/>
|
|
</issue>
|
|
|
|
<issue
|
|
id="UnusedResources"
|
|
message="The resource `R.color.teal_700` appears to be unused"
|
|
errorLine1=" <color name="teal_700">#FF018786</color>"
|
|
errorLine2=" ~~~~~~~~~~~~~~~">
|
|
<location
|
|
file="src/main/res/values/colors.xml"
|
|
line="7"
|
|
column="12"/>
|
|
</issue>
|
|
|
|
<issue
|
|
id="UnusedResources"
|
|
message="The resource `R.color.black` appears to be unused"
|
|
errorLine1=" <color name="black">#FF000000</color>"
|
|
errorLine2=" ~~~~~~~~~~~~">
|
|
<location
|
|
file="src/main/res/values/colors.xml"
|
|
line="8"
|
|
column="12"/>
|
|
</issue>
|
|
|
|
<issue
|
|
id="UnusedResources"
|
|
message="The resource `R.color.white` appears to be unused"
|
|
errorLine1=" <color name="white">#FFFFFFFF</color>"
|
|
errorLine2=" ~~~~~~~~~~~~">
|
|
<location
|
|
file="src/main/res/values/colors.xml"
|
|
line="9"
|
|
column="12"/>
|
|
</issue>
|
|
|
|
</issues>
|