REDI-101: replace em/en dashes with hyphens in prose & comments

Em dashes are a common AI-writing tell; swap them (and en dashes) for plain
hyphens across the README and all KDoc/comment prose so the repo reads as
hand-authored. Byte-level replace of U+2014/U+2013 -> '-'; arrows and the
ellipsis are left untouched.

The two functional em dashes are intentionally kept: the `DASH = "—"`
blank-field UI placeholder in CharacterDetailUi and the preview sample that
mirrors it -- those are deliberate UX, not prose.

feature/characters/presentation/build.gradle.kts

@@ -18,7 +18,7 @@ dependencies {
     implementation(libs.androidx.lifecycle.viewmodel.ktx)
     implementation(libs.androidx.lifecycle.viewmodel.savedstate)
     implementation(libs.kotlinx.coroutines.android)
-    // Stable collection for state — makes the list Compose-stable WITHOUT a Compose dependency,
+    // Stable collection for state - makes the list Compose-stable WITHOUT a Compose dependency,
     // so this module stays UI-agnostic (no @Stable annotation, which would require compose-runtime).
     // `api` because CharacterListState.characters exposes ImmutableList in the public state API.
     api(libs.kotlinx.collections.immutable)

feature/characters/presentation/src/main/kotlin/com/example/architecture/feature/characters/presentation/CharacterDetailViewModel.kt

@@ -19,7 +19,7 @@ import kotlinx.coroutines.launch
  * UI-agnostic MVI ViewModel for the character detail screen.
  *
  * Type-safe navigation writes the route's typed `characterId` into [SavedStateHandle] under its
- * field name. Reading that raw key — instead of `savedStateHandle.toRoute<CharacterDetailRoute>()` —
+ * field name. Reading that raw key - instead of `savedStateHandle.toRoute<CharacterDetailRoute>()` -
  * is deliberate: it keeps this module free of any navigation/Compose dependency (the route type
  * lives in the renderer). The renderer is what reads the route via `toRoute()`.
  */

feature/characters/presentation/src/main/kotlin/com/example/architecture/feature/characters/presentation/CharacterListState.kt

@@ -8,7 +8,7 @@ import kotlinx.collections.immutable.persistentListOf
 /**
  * The single source of UI state for the characters list. Deliberately Compose-free: instead of the
  * `@Stable` annotation (which lives in compose-runtime), the list is an [ImmutableList], which
- * Compose already treats as stable — so this module needs no Compose dependency. Navigation and
+ * Compose already treats as stable - so this module needs no Compose dependency. Navigation and
  * snackbars are one-time Events, never state.
  */
 data class CharacterListState(

feature/characters/presentation/src/main/kotlin/com/example/architecture/feature/characters/presentation/CharacterListViewModel.kt

@@ -77,7 +77,7 @@ class CharacterListViewModel(
                 page++
             }
 
-            // Always surface a failure — even a partial one where earlier pages loaded.
+            // Always surface a failure - even a partial one where earlier pages loaded.
             if (error != null) {
                 _events.send(CharacterListEvent.ShowSnackbar(error))
             }
@@ -119,7 +119,7 @@ class CharacterListViewModel(
 
     private fun loadPage(page: Int) {
         // Flip the loading flag SYNCHRONOUSLY (before launching) so a rapid second OnLoadNextPage is
-        // guarded out before its coroutine starts — otherwise the same page loads twice and items
+        // guarded out before its coroutine starts - otherwise the same page loads twice and items
         // get appended twice.
         _state.update { it.copy(isLoadingNextPage = true, error = null) }
         viewModelScope.launch {

feature/characters/presentation/src/main/kotlin/com/example/architecture/feature/characters/presentation/ErrorDemoAction.kt

@@ -4,7 +4,7 @@ sealed interface ErrorDemoAction {
     /** Force a load that fails with the given [ErrorScenario]. */
     data class OnForceError(val scenario: ErrorScenario) : ErrorDemoAction
 
-    /** Force a load that succeeds — clears any current error. */
+    /** Force a load that succeeds - clears any current error. */
     data object OnLoadSuccess : ErrorDemoAction
 
     /** Re-issue the most recent load (the design-system retry button). */

feature/characters/presentation/src/main/kotlin/com/example/architecture/feature/characters/presentation/ErrorDemoState.kt

@@ -4,8 +4,8 @@ import com.example.architecture.core.presentation.UiText
 
 /**
  * State for the error-handling demo. All fields are primitive/stable, so no `@Stable` is needed.
- * [error] is the *mapped* [UiText] produced by `DataError.toUiText()` — exactly what the real
- * screens hold — so the renderer resolves and shows it the same way.
+ * [error] is the *mapped* [UiText] produced by `DataError.toUiText()` - exactly what the real
+ * screens hold - so the renderer resolves and shows it the same way.
  */
 data class ErrorDemoState(
     val isLoading: Boolean = false,

feature/characters/presentation/src/main/kotlin/com/example/architecture/feature/characters/presentation/ErrorDemoViewModel.kt

@@ -16,7 +16,7 @@ import kotlinx.coroutines.flow.update
 import kotlinx.coroutines.launch
 
 /**
- * UI-agnostic MVI ViewModel for the **error-handling demo** — a runnable walk-through of the whole
+ * UI-agnostic MVI ViewModel for the **error-handling demo** - a runnable walk-through of the whole
  * error pipeline. A "force error" affordance produces a real [DataError.Network], which is routed
  * through the *same* steps a genuine network call uses:
  *
@@ -24,8 +24,8 @@ import kotlinx.coroutines.launch
  * Result<…, DataError.Network>  →  onSuccess / onFailure  →  DataError.toUiText()  →  ErrorState
  * ```
  *
- * The outcome is *simulated* (no real request) only so every case — including NO_INTERNET, which you
- * can't reliably trigger on demand — is reachable deterministically. [OnRetry] re-issues the last
+ * The outcome is *simulated* (no real request) only so every case - including NO_INTERNET, which you
+ * can't reliably trigger on demand - is reachable deterministically. [OnRetry] re-issues the last
  * attempt (proving retry is an Action); [OnLoadSuccess] clears the error (proving it clears on
  * success).
  */

feature/characters/presentation/src/main/kotlin/com/example/architecture/feature/characters/presentation/di/CharactersPresentationModule.kt

@@ -10,7 +10,7 @@ import org.koin.dsl.module
 
 /** Presentation DI for the characters feature. Lives with the (UI-agnostic) ViewModels it provides. */
 val charactersPresentationModule = module {
-    // Stateless domain UseCase — `factoryOf` (a fresh, cheap instance per resolution). Koin supplies
+    // Stateless domain UseCase - `factoryOf` (a fresh, cheap instance per resolution). Koin supplies
     // its CharacterRepository from charactersDataModule.
     factoryOf(::GetCharactersPageUseCase)
     viewModelOf(::CharacterListViewModel)

feature/characters/presentation/src/main/kotlin/com/example/architecture/feature/characters/presentation/model/CharacterUi.kt

@@ -3,7 +3,7 @@ package com.example.architecture.feature.characters.presentation.model
 import com.example.architecture.feature.characters.domain.model.Character
 import com.example.architecture.feature.characters.domain.model.CharacterStatus
 
-/** Presentation model for a character list item — decouples the UI from the domain [Character]. */
+/** Presentation model for a character list item - decouples the UI from the domain [Character]. */
 data class CharacterUi(
     val id: Int,
     val name: String,

feature/characters/presentation/src/test/kotlin/com/example/architecture/feature/characters/presentation/CharacterDetailViewModelTest.kt

@@ -27,7 +27,7 @@ import org.junit.jupiter.api.assertThrows
 
 /**
  * Unit tests for [CharacterDetailViewModel]. The character id arrives via [SavedStateHandle] (written
- * by type-safe navigation), which is constructed directly here — proving the VM needs no navigation
+ * by type-safe navigation), which is constructed directly here - proving the VM needs no navigation
  * dependency. The [CharacterRepository] collaborator is a *relaxed* MockK mock, so the "missing id"
  * case needs no stubbing while the rest stub `getCharacterDetails` explicitly with `coEvery`;
  * assertions use AssertK; the back event is observed with Turbine.
@@ -85,7 +85,7 @@ class CharacterDetailViewModelTest {
         advanceUntilIdle()
         assertThat(viewModel.state.value.error).isNotNull()
 
-        // Same call, new answer — the latest `coEvery` wins, so the retry attempt succeeds.
+        // Same call, new answer - the latest `coEvery` wins, so the retry attempt succeeds.
         coEvery { repository.getCharacterDetails(1) } returns Result.Success(characterDetails(1))
         viewModel.onAction(CharacterDetailAction.OnRetry)
         advanceUntilIdle()

feature/characters/presentation/src/test/kotlin/com/example/architecture/feature/characters/presentation/CharacterListViewModelTest.kt

@@ -33,7 +33,7 @@ import org.junit.jupiter.api.BeforeEach
 import org.junit.jupiter.api.Test
 
 /**
- * Unit tests for [CharacterListViewModel] — driven entirely through its public MVI surface
+ * Unit tests for [CharacterListViewModel] - driven entirely through its public MVI surface
  * (State/Action/Event), so they prove the VM correct regardless of which renderer hosts it.
  *
  * Uses [StandardTestDispatcher] (not Unconfined) so launched work is queued until `advanceUntilIdle`,
@@ -159,7 +159,7 @@ class CharacterListViewModelTest {
             viewModel.onAction(CharacterListAction.OnLoadNextPage)
             advanceUntilIdle()
 
-            // Only the single initial load ran — the guarded next-page request never fired.
+            // Only the single initial load ran - the guarded next-page request never fired.
             coVerify(exactly = 1) { repository.getCharacters(1) }
             coVerify(exactly = 0) { repository.getCharacters(2) }
         }